Enable ruff's pylint rules (PL) and remove pylint #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelgrund
approved these changes
Nov 20, 2023
seisman
added
final review call
weiji14
reviewed
Nov 21, 2023
| @@ -204,7 +204,7 @@ def convention_params(convention): | |||
| t="transparency", | |||
| ) | |||
| @kwargs_to_strings(R="sequence", c="sequence_comma", p="sequence") | |||
| def meca( | |||
| def meca( # noqa: PLR0912, PLR0913, PLR0915 | |||
There was a problem hiding this comment.
Hmm, doesn't look like ruff supports human-friendly rule names yet (e.g. disable=too-many-arguments,too-many-locals,too-many-branches) - astral-sh/ruff#1773
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
approved these changes
Nov 21, 2023
seisman
removed
the
final review call
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR enables ruff's pylint rules (PL) and everything look good to me. So fully remove pylint from the project.
Address #2741 (comment)
Reference: https://docs.astral.sh/ruff/faq/#how-does-ruffs-linter-compare-to-pylint